Add Carmen integration#1
Merged
Merged
Conversation
thaarok
force-pushed
the
jkalina/carmen-into-opera
branch
2 times, most recently
from
b75d021 to
b4f9b96
Compare
HerbertJordan
requested changes
May 17, 2023
Collaborator
HerbertJordan
left a comment
HerbertJordan
left a comment
There was a problem hiding this comment.
Great work, thanks!
I have just a few minor requests and questions, please see the individual comments.
thaarok
force-pushed
the
jkalina/carmen-into-opera
branch
from
b4f9b96 to
11bc1f8
Compare
thaarok
force-pushed
the
jkalina/carmen-into-opera
branch
from
11bc1f8 to
997baa2
Compare
Collaborator
Author
|
Updated:
|
HerbertJordan
approved these changes
May 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems working ok with fakenet 1/1.
Prepared to be tested in Norma.
Use
--statedb.impl=go-fileto run with Carmen.Stopping needs to be handled yet, need to remove the datadir after each run for now.